Fix #609 (default arguments for GenericModel)

[dmontagu]

Fix #609 (default arguments for GenericModel)

Checklist

• Unit tests for the changes exist
• Tests pass on CI and coverage remains at 100%
• Documentation reflects the changes where applicable
• HISTORY.rst has been updated

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@3ee54ed). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master   #610   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     15           
  Lines             ?   2582           
  Branches          ?    510           
=======================================
  Hits              ?   2582           
  Misses            ?      0           
  Partials          ?      0

[samuelcolvin]

maybe we should add a test for the case of a default as per the issue

def test_default_arguments():
    T = TypeVar('T')

    class Result(GenericModel, Generic[T]):
        data: T
        other: bool = True
    result = Result[int](data=1)

?

[dmontagu]

maybe we should add a test for the case of a default as per the issue

def test_default_arguments():
    T = TypeVar('T')

    class Result(GenericModel, Generic[T]):
        data: T
        other: bool = True
    result = Result[int](data=1)

?

Sorry my comments were confusing -- when I said I added tests not directly related, I meant in addition to one that was.

The following test was already committed:

@skip_36
def test_default_arguments():
    T = TypeVar('T')

    class Result(GenericModel, Generic[T]):
        data: T
        other: bool = True

    result = Result[int](data=1)
    assert result.other is True

Let me know if that's not enough

[samuelcolvin]

sound more double quotes I'm afraid :-). Promise I'll do linting for this soon.

Also, what about

class Result(GenericModel, Generic[T]):
    data: T = 4

Does that work fine? Maybe worth adding a test?

[dmontagu]

sound more double quotes I'm afraid :-). Promise I'll do linting for this soon.

+1 here's an option

Also, what about

class Result(GenericModel, Generic[T]):
    data: T = 4

Does that work fine? Maybe worth adding a test?

I'm not sure if I should be reading anything special into this (e.g., raise errors if T isn't numeric at model creation time?), but it appears to work correctly (or at least, the same as it would if inheriting from BaseModel with T replaced). I added the test.