-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add alias_generator #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alias_generator #622
Conversation
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 2628 2634 +6
Branches 516 518 +2
=====================================
+ Hits 2628 2634 +6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise mostly looks good to me.
How do we cope with #624 which I hope to implement soon? Three different functions or the method could alternatively return a 3-tuple? Either of these solutions could be implemented later and would be backwards compatible.
Move docs to config section, reformat example Separate test_alias_generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM.
Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>
Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>
Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, noticed something else.
…fig.alias_generator Add one more condition for applying alias_generator Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>
|
great, thank you very much. |
Change Summary
Add
Config.alias_generatorthat provides ability to convert name to alias for each field of model. See docs example:Related issue number
None
Checklist
HISTORY.rsthas been updated