Skip to content

Fix unparameterized generic type schema generation #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 2, 2019
Merged

Fix unparameterized generic type schema generation #625

merged 5 commits into from
Jul 2, 2019

Conversation

dmontagu
Copy link
Contributor

Change Summary

Fixes #623 as described by @samuelcolvin (unparameterized generic types will not have restrictions on the parameterized types).

Related issue number

#623

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>

@dmontagu dmontagu force-pushed the fix-partial-type-schema branch from 38506ff to af99c21 Compare June 27, 2019 09:42
@dmontagu dmontagu changed the title Fix #623 Fix unparameterized generic type schema generation Jun 27, 2019
samuelcolvin
samuelcolvin reviewed Jun 27, 2019
View reviewed changes
@codecov
Copy link

codecov bot commented Jun 27, 2019 •
edited
Loading

Codecov Report

Merging #625 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #625   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines        2628   2628           
  Branches      516    516           
=====================================
  Hits         2628   2628

@drunkwcodes drunkwcodes mentioned this pull request Jun 27, 2019
Closed
@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #625 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #625   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines        2628   2628           
  Branches      516    516           
=====================================
  Hits         2628   2628

@samuelcolvin samuelcolvin merged commit 8aac71a into pydantic:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin samuelcolvin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible to give a more useful error message on partial type?
2 participants
@dmontagu @samuelcolvin