New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch up Decimal validator #6327
Conversation
This improves performance slightly by not always going through Python, but error messages actually get less intelligle
Deploying with Cloudflare Pages
|
76b8557
to
d1eee58
Compare
This improves performance slightly by not always going through Python, but error messages actually get less intelligle
… into touch-up-decimal
please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me if there's a good performance improvement but we really need to fix these error messages. In particular, I think there should be a way to have a union schema where you don't get an error for every possible case, among other things, as is it seems painfully verbose. But that's not a problem introduced by this PR
Agreed! |
This improves performance slightly by not always going through Python, but error messages actually get less intelligible.
skip change file check
Selected Reviewer: @dmontagu