Touch up Decimal validator #6327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves performance slightly by not always going through Python, but error messages actually get less intelligle
Deploying with
|
| Latest commit: |
5d97970
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e2e2e764.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://touch-up-decimal.pydantic-docs2.pages.dev |
adriangb
force-pushed
the
touch-up-decimal
branch
from
76b8557 to
d1eee58
Compare
This improves performance slightly by not always going through Python, but error messages actually get less intelligle
… into touch-up-decimal
|
please review |
4 tasks
dmontagu
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Seems fine to me if there's a good performance improvement but we really need to fix these error messages. In particular, I think there should be a way to have a union schema where you don't get an error for every possible case, among other things, as is it seems painfully verbose. But that's not a problem introduced by this PR
|
Agreed! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance slightly by not always going through Python, but error messages actually get less intelligible.
skip change file check
Selected Reviewer: @dmontagu