Fix issue with union parsing of enums #6440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
397c3c4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3de20f36.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://dmontagu-6438.pydantic-docs2.pages.dev |
dmontagu
commented
Jul 4, 2023
| strict_python_schema = core_schema.is_instance_schema(enum_type) | ||
| if use_enum_values: | ||
| strict_python_schema = core_schema.chain_schema( | ||
| [strict_python_schema, core_schema.no_info_plain_validator_function(lambda x: x.value)] |
There was a problem hiding this comment.
I think what happens is that, when parsing unions, it tries to parse in strict mode first so that it gets the right union case, rather than the first one, when possible. Because the strict mode python schema wasn't applying the use_enum_values thing before, it didn't affect the parsing of unions.
I guess it was also a bug that if you were to validate an enum in strict mode with use_enum_values=True it wouldn't actually use the enum values either. I've added a test for that below (and did confirm it fails on main)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6438