Skip to content

Conversation

tpdorsey
Copy link
Contributor

@tpdorsey tpdorsey commented Jul 6, 2023

Change Summary

Related issue number

Closes PYD-116

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@linear
Copy link

linear bot commented Jul 6, 2023

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f4009f0
Status: ✅  Deploy successful!
Preview URL: https://2dff25f6.pydantic-docs2.pages.dev
Branch Preview URL: https://json-schema-docs.pydantic-docs2.pages.dev

View logs

tpdorsey and others added 2 commits July 7, 2023 08:53
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@tpdorsey
Copy link
Contributor Author

tpdorsey commented Jul 7, 2023

please review

Copy link
Member

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some notes but generally looks good!

@tpdorsey tpdorsey merged commit ac576b6 into main Jul 10, 2023
@tpdorsey tpdorsey deleted the json-schema-docs branch July 10, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants