Fix ci #6507
Merged
Fix ci #6507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
5408752
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://db34752d.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://fix-ci-2.pydantic-docs2.pages.dev |
|
I wasn't able to use |
|
please review |
Kludex
approved these changes
Jul 7, 2023
5 tasks
lig
suggested changes
Jul 7, 2023
Comment on lines
252
to
+256
| typing-extensions-version: ['4.6.1', 'main'] | ||
| python-version: ['3.7', '3.8', '3.9', '3.10', '3.11'] | ||
| python-version: ['3.8', '3.9', '3.10', '3.11'] | ||
| include: | ||
| - typing-extensions-version: '4.6.1' | ||
| python-version: '3.7' |
There was a problem hiding this comment.
Why do we even need 4.6.1 here? As far as I can see, we just do simple make test.
I think it's enough to run against main here. Thus, this could be just a list of python versions and no else branch in the install typing-extensions step.
There was a problem hiding this comment.
The idea is to test the oldest version we support and the latest version on every python version we support
There was a problem hiding this comment.
make test could very well fail if .e.g we import a symbol that doesn't exist
pydantic-hooky
bot
added
awaiting author revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip change file check
Selected Reviewer: @davidhewitt