Defer evaluation of return type hints for serializer functions #6516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to add tests please update (for myself) |
pydantic-hooky
bot
added
the
awaiting author revision
Deploying with
|
| Latest commit: |
c368e01
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://424edfa9.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://defer-serializer-return-type.pydantic-docs2.pages.dev |
adriangb
reviewed
Jul 7, 2023
adriangb
reviewed
Jul 7, 2023
adriangb
approved these changes
Jul 7, 2023
dmontagu
force-pushed
the
defer-serializer-return-type-evaluation
branch
from
38bfd3d to
19bf9a7
Compare
|
please review |
pydantic-hooky
bot
added
ready for review
and removed
awaiting author revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6489
Also fixes the same issue for
PlainSerializeretc.skip change file check
Selected Reviewer: @Kludex