add "north star" benchmark #6547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
dh/north-star
branch
from
0e83586
to
380deab
Compare
Deploying with
|
| Latest commit: |
20345c2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9f10cd69.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://dh-north-star.pydantic-docs2.pages.dev |
davidhewitt
force-pushed
the
dh/north-star
branch
4 times, most recently
from
d68aa64
to
3f48145
Compare
|
please review |
hramezani
approved these changes
Jul 11, 2023
4 tasks
davidhewitt
force-pushed
the
dh/north-star
branch
from
3f48145
to
572bdcd
Compare
davidhewitt
force-pushed
the
dh/north-star
branch
from
572bdcd
to
20345c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This adds a new
tests/benchmarksdirectory containing a "north star" benchmark which contains a first start at a benchmark to use to understand how changes affect performance.I suspect the bulk of meaningful changes will come to changes in
pydantic-core, so I'd like to find a way to run these same benchmarks onpydantic-corePRs.skip change file check
Related issue number
N/A
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)
Selected Reviewer: @hramezani