🐛 Fix max_length for unicode strings
#6559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on pydantic/pydantic-core#758 |
lig
force-pushed
the
lig/6542-str-field-max_length-constraint-panics-on-unicode-characters
branch
from
927b336 to
8a528b8
Compare
Deploying with
|
| Latest commit: |
fc5d855
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b9ec3a6e.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://lig-6542-str-field-max-lengt.pydantic-docs2.pages.dev |
lig
force-pushed
the
lig/6542-str-field-max_length-constraint-panics-on-unicode-characters
branch
from
8a528b8 to
fc5d855
Compare
|
please review |
adriangb
approved these changes
Jul 11, 2023
lig
deleted the
lig/6542-str-field-max_length-constraint-panics-on-unicode-characters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Update pydantic-core and add tests for
max_lengthbehavior with unicode charactersRelated issue number
Fix #6542
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)
Selected Reviewer: @adriangb