Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alias_generator and field config conflict

Merged

Conversation

Bobronium
Copy link
Contributor

@Bobronium Bobronium commented Jul 13, 2019

Change Summary

alias_generator will work if field has extra values in schema, but no 'alias' specified

Related issue number

#645

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • HISTORY.rst has been updated
    • if this is the first change since a release, please add a new section
    • include the issue number or this pull request number #<number>
    • include your github username @<whomever>

@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #658 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #658   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines        2712   2712           
  Branches      537    537           
=====================================
  Hits         2712   2712

@Bobronium
Copy link
Contributor Author

Bobronium commented Jul 13, 2019

@gmetzker, check this out please :)

Copy link
Collaborator

@samuelcolvin samuelcolvin left a comment

LGTM, just rebase and update HISTORY I'm afraid (sorry, will move to towncrier or similar soon).

@gmetzker
Copy link

gmetzker commented Jul 18, 2019

@gmetzker, check this out please :)

I tried your branch and it indeed fixed the issue. Thx @MrMrRobat

@Bobronium
Copy link
Contributor Author

Bobronium commented Jul 19, 2019

@samuelcolvin, I gues we ready for merge!

@samuelcolvin samuelcolvin merged commit 1b4c1a8 into pydantic:master Jul 24, 2019
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants