Add StringConstraints for use as Annotated metadata #6605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
Deploying with
|
| Latest commit: |
fa297ec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9edc9c6e.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://add-stringconstraints.pydantic-docs2.pages.dev |
|
ready now :) |
hramezani
reviewed
Jul 12, 2023
hramezani
reviewed
Jul 12, 2023
hramezani
approved these changes
Jul 12, 2023
|
Should we add documentation now? |
Yes good call |
1 task
|
please update - add docs. |
|
please review |
adriangb
force-pushed
the
add-StringConstraints
branch
from
b5673d9
to
d708133
Compare
Are y'all aware you've documented the feature but not released it? I just spent an hour trying to figure out why I can't import |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6506
Selected Reviewer: @samuelcolvin