Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review json_schema.md #6608

Merged
merged 1 commit into from Jul 12, 2023
Merged

Review json_schema.md #6608

merged 1 commit into from Jul 12, 2023

Conversation

tpdorsey
Copy link
Contributor

@tpdorsey tpdorsey commented Jul 11, 2023 •
edited by pydantic-hooky bot

Review and minor edits for json_schema.md

Change Summary

Related issue number

Closes PYD-61

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

@linear
Copy link

linear bot commented Jul 11, 2023

PYD-61 Review usage docs: usage/json_schema.md

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e0700c5
Status: ✅  Deploy successful!
Preview URL: https://f1d8dacd.pydantic-docs2.pages.dev
Branch Preview URL: https://review-json-schema.pydantic-docs2.pages.dev

View logs

@tpdorsey
Copy link
Contributor Author

please review

@Kludex Kludex merged commit b8ad578 into main Jul 12, 2023
48 checks passed
@Kludex Kludex deleted the review-json-schema branch July 12, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramezani hramezani hramezani approved these changes

@Kludex Kludex Kludex approved these changes

Assignees

@dmontagu dmontagu

Labels
documentation ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tpdorsey @hramezani @Kludex @dmontagu