Make it work to use None as a generic parameter #6609
Conversation
| @@ -702,8 +702,6 @@ def _generate_dc_field_schema( | |||
| ) | |||
|
|
|||
| def _common_field_schema(self, name: str, field_info: FieldInfo, decorators: DecoratorInfos) -> _CommonField: | |||
| assert field_info.annotation is not None, 'field_info.annotation should not be None when generating a schema' | |||
There was a problem hiding this comment.
I thought this assertion was safe and that we couldn't hit this branch, but apparently we need to handle this case.
I think ideally the defaults for FieldInfo would be PydanticUndefined rather than None, in which case it would make sense to retain the check. But that would be a breaking change at this point.
There was a problem hiding this comment.
Would that be an unreasonable breaking change? It's to fix a bug.
There was a problem hiding this comment.
I think so, since people do inspect the FieldInfos. And it's not necessary here, that check was just to catch it if there was some other more fundamental bug which presumably doesn't exist (currently). I think it's better to just drop the check and a small amount of hypothetical safety instead of a change that will almost certainly cause issues for at least some people.
Deploying with
|
| Latest commit: |
90b2819
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e40fea2a.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://none-generic-parameter.pydantic-docs2.pages.dev |
Closes #6548