Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pydantic dataclass problem with dataclasses.field default_factory #6616

Merged
merged 1 commit into from Jul 12, 2023
Merged

Fix pydantic dataclass problem with dataclasses.field default_factory #6616

merged 1 commit into from Jul 12, 2023

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Jul 12, 2023 •
edited by pydantic-hooky bot

Fixes #6600

Selected Reviewer: @davidhewitt

@hramezani
Copy link
Member Author

please review

davidhewitt
davidhewitt approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hramezani hramezani merged commit 3026172 into main Jul 12, 2023
48 checks passed
@hramezani hramezani deleted the dataclass_filed_default_factory branch July 12, 2023 12:25
@PrettyWood PrettyWood mentioned this pull request Oct 21, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees

@davidhewitt davidhewitt

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instance of Pydantic dataclass with field(default_factory=..., init=False) is missing this attribute
2 participants
@hramezani @davidhewitt