Skip to content

🐛 Support defining json_schema_extra on RootModel using Field #6622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2023
Merged

🐛 Support defining json_schema_extra on RootModel using Field #6622

merged 2 commits into from
Jul 12, 2023

Conversation

lig
Copy link
Contributor

@lig lig commented Jul 12, 2023 •
edited by pydantic-hooky bot
Loading

Change Summary

Add support for json_schema_extra using Field on Root.root

Related issue number

Fix #6579

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

@lig lig marked this pull request as ready for review July 12, 2023 13:35
@lig
Copy link
Contributor Author

lig commented Jul 12, 2023

please review

dmontagu
dmontagu reviewed Jul 12, 2023
View reviewed changes
dmontagu
dmontagu approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@dmontagu dmontagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the suggested change to the error message, LGTM

@lig lig enabled auto-merge (squash) July 12, 2023 14:02
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 12, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 861254c
Status: ✅  Deploy successful!
Preview URL: https://170df6ff.pydantic-docs2.pages.dev
Branch Preview URL: https://lig-6579.pydantic-docs2.pages.dev

View logs

@lig @dmontagu
Update pydantic/json_schema.py
861254c 
Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
@lig lig merged commit 176714d into main Jul 12, 2023
@lig lig deleted the lig/6579 branch July 12, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmontagu dmontagu dmontagu approved these changes

Assignees

@dmontagu dmontagu

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Field(json_schema_extra=...) is missing in schema with RootModel
2 participants
@lig @dmontagu