Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix validation warning for unions of Literal and other type #6628

Merged
merged 1 commit into from Jul 21, 2023
Merged

🐛 Fix validation warning for unions of Literal and other type #6628

merged 1 commit into from Jul 21, 2023

Conversation

lig
Copy link
Contributor

@lig lig commented Jul 12, 2023 •
edited by pydantic-hooky bot

Change Summary

Reproduce the issue

Related issue number

Fix #6601

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @hramezani

@lig lig mentioned this pull request Jul 12, 2023
Closed
1 task
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 12, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a448561
Status: ✅  Deploy successful!
Preview URL: https://8ceecb86.pydantic-docs2.pages.dev
Branch Preview URL: https://lig-6601.pydantic-docs2.pages.dev

View logs

@lig
Copy link
Contributor Author

lig commented Jul 17, 2023

depends on pydantic/pydantic-core#783

@lig lig marked this pull request as ready for review July 20, 2023 14:22
@lig
Copy link
Contributor Author

lig commented Jul 20, 2023

please review

hramezani
hramezani reviewed Jul 20, 2023
View reviewed changes
tests/test_edge_cases.py Outdated Show resolved Hide resolved
@lig lig requested a review from hramezani July 20, 2023 16:38
@lig
Copy link
Contributor Author

lig commented Jul 20, 2023

please review

@lig lig merged commit 1aac3d8 into main Jul 21, 2023
48 checks passed
@lig lig deleted the lig/6601 branch July 21, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramezani hramezani hramezani approved these changes

Assignees

@hramezani hramezani

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serialization warning with tp.Literal[False] | str
2 participants
@lig @hramezani