simplify slots_dataclass construction to appease mypy #6639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
d402f86
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3175a966.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://dh-slots-dataclass.pydantic-docs2.pages.dev |
davidhewitt
force-pushed
the
dh/slots-dataclass
branch
from
5816e99 to
d402f86
Compare
|
please review |
samuelcolvin
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
mypydoesn't appear to be happy with the way theslots_dataclasswraps dataclass. I think it fails to recognise the annotated class as a dataclass.In this PR I propose an alternative way to switch slots for Python 3.10 and up by just passing a mapping
**slots_trueto the standard dataclass constructor. (The mapping is{'slots': True}on 3.10 and up, otherwise empty.)Related issue number
Fixes #6544
Checklist
Selected Reviewer: @samuelcolvin