Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typehint for JSON schema extra callable #6659

Merged
merged 1 commit into from Jul 13, 2023

Conversation

dmontagu
Copy link
Contributor

@dmontagu dmontagu commented Jul 13, 2023

closes #6494

Selected Reviewer: @davidhewitt

@dmontagu
Copy link
Contributor Author

please review

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8005e51
Status: ✅  Deploy successful!
Preview URL: https://91a508ab.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-json-schema-extra-callab.pydantic-docs2.pages.dev

View logs

@dmontagu dmontagu merged commit 8225ab5 into main Jul 13, 2023
48 checks passed
@dmontagu dmontagu deleted the fix-json-schema-extra-callable-typehint branch July 13, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonSchemaExtraCallable callback protocol doesn't type check correctly for acceptable functions
3 participants