Skip to content

Conversation

dmontagu
Copy link
Contributor

@dmontagu dmontagu commented Jul 13, 2023

Closes #6426

Note that this is the relevant code in typing_extensions:

# 3.7.2+
if hasattr(typing, 'OrderedDict'):
    OrderedDict = typing.OrderedDict
# 3.7.0-3.7.2
else:
    OrderedDict = typing._alias(collections.OrderedDict, (KT, VT))

Given that, I think this is safe to merge. @Kludex I understand where you are coming from with not fixing it but given its so simple I think it's worth just doing it.

Selected Reviewer: @adriangb

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4eba030
Status: ✅  Deploy successful!
Preview URL: https://0256a439.pydantic-docs2.pages.dev
Branch Preview URL: https://typing-extensions-ordered-di.pydantic-docs2.pages.dev

View logs

@dmontagu
Copy link
Contributor Author

Please review

@dmontagu dmontagu merged commit e27243d into main Jul 13, 2023
@dmontagu dmontagu deleted the typing-extensions-ordered-dict branch July 13, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not compatible with python 3.7.1
2 participants