Remove the Validate always section in validator docs #6679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
43daf05
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://27d9ef2f.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://remove-validate-default-in-d.pydantic-docs2.pages.dev |
|
please review |
ybressler
reviewed
Jul 14, 2023
Comment on lines
-324
to
-330
| ## Validate always | ||
|
|
||
| **TODO this content is wrong!** | ||
|
|
||
| For performance reasons, by default validators are not called for fields when a value is not supplied. | ||
| However there are situations where it may be useful or required to always call the validator, e.g. | ||
| to set a dynamic default value. |
There was a problem hiding this comment.
I would argue it is important to keep the section, but describe behavior instead. You can use validate_defaults to perform validation always...
There was a problem hiding this comment.
The reality of the matter is that (1) these docs as they currently are do not help and (2) many of the requests we get for this feature either are better solved in another manner or have big drawbacks. We can re-add docs when we find a simple example that this is the right fit for, once we get actual users requesting this that can only be solved by this option, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected Reviewer: @lig