Skip to content

Conversation

dmontagu
Copy link
Contributor

@dmontagu dmontagu commented Jul 14, 2023

closes #5329

Selected Reviewer: @samuelcolvin

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 14, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c9804f3
Status: ✅  Deploy successful!
Preview URL: https://2c614a06.pydantic-docs2.pages.dev
Branch Preview URL: https://improve-validate-call-error.pydantic-docs2.pages.dev

View logs

@dmontagu
Copy link
Contributor Author

please review

Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that passes, LGTM.

@samuelcolvin samuelcolvin enabled auto-merge (squash) July 18, 2023 09:05
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests failing.

@pydantic-hooky pydantic-hooky bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels Jul 24, 2023
@pydantic-hooky pydantic-hooky bot assigned dmontagu and unassigned samuelcolvin Jul 24, 2023
@dmontagu
Copy link
Contributor Author

please review

@pydantic-hooky pydantic-hooky bot added ready for review and removed awaiting author revision awaiting changes from the PR author labels Jul 25, 2023
@pydantic-hooky pydantic-hooky bot assigned samuelcolvin and unassigned dmontagu Jul 25, 2023
@samuelcolvin samuelcolvin merged commit 2db6248 into main Jul 25, 2023
@samuelcolvin samuelcolvin deleted the improve-validate-call-error-message branch July 25, 2023 14:42
@samuelcolvin
Copy link
Member

TYVM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@validate_arguments gives a confusing error if put above @classmethod
2 participants