Add benchmark for valideer #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 19 19
Lines 3237 3237
Branches 642 642
=====================================
Hits 3237 3237Continue to review full report at Codecov.
|
|
Thanks so much for this, sorry I haven't dealt with it. I'm going to defer further changes to benchmarks until after v1 (see #576), but after that I promise to deal with this. Sorry again for the delay. |
|
Sure no rush, thanks for the update. |
samuelcolvin
added
the
deferred
samuelcolvin
removed
the
deferred
|
I've merged master, and updated benchmarks. I'll merge this once tests pass. valideer is still the fasted other than pydantic :-) |
|
Great, thank you! |
andreshndz
pushed a commit
to cuenca-mx/pydantic
that referenced
this pull request
Jan 17, 2020
* Add benchmark for valideer * valideer version and update benchmarks * add change * correct benchmarks
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new benchmark for Valideer, yet another validation library (Disclaimer: I am the main author).
Despite the fact that high performance was not among valideer's goals and that it is a pure python package written ~7 years ago, it appears to be as fast as pydantic when the latter is compiled with Cython and 1.6x faster when not. Here are some benchmark results on python 3.6.7:
Package versions: