Skip to content

Conversation

adriangb
Copy link
Member

@adriangb adriangb commented Jul 19, 2023

Fixes #6752

Selected Reviewer: @hramezani

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 224061f
Status: ✅  Deploy successful!
Preview URL: https://37cc488b.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-inspect-builtins.pydantic-docs2.pages.dev

View logs

@adriangb
Copy link
Member Author

please review

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please can we add a test.

@adriangb
Copy link
Member Author

Yup sorry forgot to push it

@adriangb adriangb enabled auto-merge (squash) July 19, 2023 14:02
@adriangb adriangb merged commit 98a8d56 into main Jul 19, 2023
@adriangb adriangb deleted the fix-inspect-builtins branch July 19, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BeforeValidator(str) raises value error
3 participants