Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix annotated_types.MaxLen validator for custom sequence types #6809

Merged
merged 3 commits into from Jul 24, 2023
Merged

Fix annotated_types.MaxLen validator for custom sequence types #6809

merged 3 commits into from Jul 24, 2023

Conversation

ImogenBits
Copy link
Contributor

@ImogenBits ImogenBits commented Jul 22, 2023 •
edited by pydantic-hooky bot

Change Summary

Makes the validator function used for annotated_types.MaxLen with custom sequences use an inclusive upper bound.

Related issue number

fix #6808

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

@ImogenBits
Copy link
Contributor Author

please review

didn't add any unit tests as I'm not sure where they would go, can't find any similar ones.

@hramezani
Copy link
Member

Thanks @ImogenBits for this patch 👍

didn't add any unit tests as I'm not sure where they would go, can't find any similar ones.

You can adjust the test in

pydantic/tests/test_types.py

Line 5379 in 5320764

def test_constraints_arbitrary_type() -> None:

please update

@pydantic-hooky pydantic-hooky bot assigned ImogenBits and unassigned dmontagu Jul 23, 2023
@hramezani
Copy link
Member

please review

@pydantic-hooky pydantic-hooky bot assigned dmontagu and unassigned ImogenBits Jul 24, 2023
@hramezani
Copy link
Member

Please review

@samuelcolvin samuelcolvin enabled auto-merge (squash) July 24, 2023 20:00
@samuelcolvin samuelcolvin merged commit 9fe3802 into pydantic:main Jul 24, 2023
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramezani hramezani hramezani left review comments

@samuelcolvin samuelcolvin samuelcolvin approved these changes

Assignees

@dmontagu dmontagu

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MaxLen annotation validator for custom sequences is incorrect
4 participants
@ImogenBits @hramezani @samuelcolvin @dmontagu