Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove email validation from the north star benchmark #6816

Merged
merged 1 commit into from Jul 24, 2023

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Jul 24, 2023

Change Summary

Removes the email field from the "north star" benchmark. The email validation is implemented in pure python and is a very complex problem, so performs significantly slower than the rest of pydantic's validation. (Approx 75% of the time was spent in email validation.)

Removing it gives us a truer measurement on the performance of pydantic's internals.

Related issue number

N/A

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @lig

@davidhewitt
Copy link
Contributor Author

please review

@davidhewitt davidhewitt enabled auto-merge (squash) July 24, 2023 09:08
@davidhewitt davidhewitt merged commit fcec0a4 into main Jul 24, 2023
45 checks passed
@davidhewitt davidhewitt deleted the dh/north-star-email branch July 24, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants