remove email validation from the north star benchmark #6816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Removes the
email
field from the "north star" benchmark. The email validation is implemented in pure python and is a very complex problem, so performs significantly slower than the rest ofpydantic
's validation. (Approx 75% of the time was spent in email validation.)Removing it gives us a truer measurement on the performance of pydantic's internals.
Related issue number
N/A
Checklist
Selected Reviewer: @lig