Improve initialization hooks example #6822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
b965ca1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c2808411.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://improve-initialization-hooks.pydantic-docs2.pages.dev |
hramezani
force-pushed
the
improve-initialization-hooks-example
branch
from
e9e3fc1
to
15f4a1f
Compare
|
Please review |
hramezani
force-pushed
the
improve-initialization-hooks-example
branch
from
15f4a1f
to
b014f3d
Compare
Kludex
approved these changes
Jul 24, 2023
hramezani
force-pushed
the
improve-initialization-hooks-example
branch
from
b014f3d
to
48906a9
Compare
There is a line after this code block that says
I've change it to make it more clear |
Kludex
reviewed
Jul 24, 2023
docs/usage/dataclasses.md
Outdated
Comment on lines
404
to
409
| * Before model validator. | ||
| * Before field validator. | ||
| * After field validator. | ||
| * Field type validators. e.g. validation for types like `int`, `str`, ... . | ||
| * `__post_init__`. | ||
| * After model validator. |
There was a problem hiding this comment.
I think model_validator(mode='before'), field_validator(mode='before'), etc. notation looks better. 👀
Also, I think we call the "Field type validators" differently in the rest of the documentation? 🤔 Inner validator? I'm not sure...
There was a problem hiding this comment.
Ok, look better.
I changed them.
Kludex
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6806
Selected Reviewer: @samuelcolvin