Skip to content

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Jul 25, 2023

closes #6834

Selected Reviewer: @lig

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 33f118f
Status: ✅  Deploy successful!
Preview URL: https://fd59395d.pydantic-docs2.pages.dev
Branch Preview URL: https://update-serialization-doc.pydantic-docs2.pages.dev

View logs

@hramezani
Copy link
Member Author

please review

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to deprecate Field.include, and FieldInfo.include

include: bool | None = _Unset,

Will you do that on a separate PR?

@samuelcolvin
Copy link
Member

please update.

@pydantic-hooky pydantic-hooky bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels Jul 25, 2023
@pydantic-hooky pydantic-hooky bot assigned hramezani and unassigned lig Jul 25, 2023
@hramezani
Copy link
Member Author

also need to deprecate Field.include, and FieldInfo.include

include: bool | None = _Unset,

Will you do that on a separate PR?

Yes, I will

@hramezani
Copy link
Member Author

please review

@pydantic-hooky pydantic-hooky bot added ready for review and removed awaiting author revision awaiting changes from the PR author labels Jul 25, 2023
@pydantic-hooky pydantic-hooky bot assigned lig and unassigned hramezani Jul 25, 2023
@samuelcolvin samuelcolvin merged commit 0ff63bf into main Jul 25, 2023
@samuelcolvin samuelcolvin deleted the update_serialization_doc branch July 25, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exclude/include in model_dump vs. exclude/include in the Field constructor
3 participants