Fix issue where generic models couldn't be parametrized with BaseModel #6933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
1 task
Deploying with
|
| Latest commit: |
7ea383f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1cec1c2e.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://fix-generic-parametrized-wit.pydantic-docs2.pages.dev |
hramezani
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6931
The issue is that the
BaseModelclass, specifically, is lying about some of its attribute annotations and doesn't have certain attributes that every subclass would have (namely,__pydantic_generic_metadata__). Fortunately, the affected functions are currently only used in ways where they shouldn't do anything interesting forBaseModel, so I just modified them to not return True forBaseModelitself, and it seems everything "just works" with that change.