Remove xfail for discriminated union with alias #6938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
ba977c7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://65dc9938.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://remove-xfail-for-discriminat.pydantic-docs2.pages.dev |
adriangb
approved these changes
Jul 29, 2023
commonism
added a commit
to commonism/aiopenapi3
that referenced
this pull request
Jul 30, 2023
commonism
added a commit
to commonism/aiopenapi3
that referenced
this pull request
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adriangb I think you were the one that made this test xfail before. I'm thinking it got updated but just not .. fully updated, and it seems to be behaving as desired now, so I figured I'd just fix it up and drop the xfail. But if I'm missing something and this is actually misbehaving, we can leave it alone.