Improve error message for NameEmail #6939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmontagu
commented
Jul 28, 2023
Comment on lines
+826
to
+828
| assert exc_info.value.errors() == [ | ||
| {'input': 1, 'loc': ('v',), 'msg': 'Input is not a valid NameEmail', 'type': 'name_email_type'} | ||
| ] |
There was a problem hiding this comment.
On current main branch, you get:
[{'ctx': {'class': 'NameEmail'},
'input': 1,
'loc': ('v', 'is-instance[NameEmail]'),
'msg': 'Input should be an instance of NameEmail',
'type': 'is_instance_of',
'url': 'https://errors.pydantic.dev/2.1/v/is_instance_of'},
{'input': 1,
'loc': ('v', 'str'),
'msg': 'Input should be a valid string',
'type': 'string_type',
'url': 'https://errors.pydantic.dev/2.1/v/string_type'}]
Deploying with
|
| Latest commit: |
1d6888e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://87af06da.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://fix-name-email-error.pydantic-docs2.pages.dev |
|
please review |
adriangb
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while looking into #6897 (comment)
Selected Reviewer: @Kludex