Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix broken URL in the pydantic-settings package recommendation #6995

Merged
merged 2 commits into from Aug 10, 2023

Conversation

swetjen
Copy link
Contributor

@swetjen swetjen commented Aug 2, 2023

Change Summary

Error returns a URL that 404s. Replace with latest as used a few lines above.

From:
https://docs.pydantic.dev/2.1.1/migration/#basesettings-has-moved-to-pydantic-settings
To:
https://docs.pydantic.dev/latest/migration/#basesettings-has-moved-to-pydantic-settings

please review

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

pydantic/_migration.py Outdated Show resolved Hide resolved
@hramezani
Copy link
Member

please update

@hramezani
Copy link
Member

@swetjen Could you please rebase your branch on top of main? Then the CI will be good again

swetjen and others added 2 commits August 10, 2023 17:24
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
@hramezani hramezani enabled auto-merge (squash) August 10, 2023 15:30
@hramezani hramezani merged commit efc8a69 into pydantic:main Aug 10, 2023
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants