Fix: mypy error with Settings and SettingsConfigDict
#7002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
JeanArhancet
force-pushed
the
fix/mypy-settings-config-dict
branch
from
6666168 to
e2cb3dd
Compare
hramezani
reviewed
Aug 7, 2023
hramezani
reviewed
Aug 7, 2023
|
Thanks @JeanArhancet for the fix 🙏 This LGTM 👍 test fast-api is failing that will be fixed after #7014 @dmontagu it would be great if you also take a look |
hramezani
reviewed
Aug 7, 2023
|
I filed what is believed to be a version of this issue at python/mypy#15804, and after installing this branch it seems to fix the error. 👍 |
|
@JeanArhancet please rebase on top of main. |
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
JeanArhancet
force-pushed
the
fix/mypy-settings-config-dict
branch
from
230bf31 to
6ff8ec4
Compare
davidhewitt
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Had a quick chat with @dmontagu about this offline, LGTM. Many thanks 👍
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix mypy error with
SettingsandSettingsConfigDictRelated issue number
Fix #6985
Checklist
Selected Reviewer: @davidhewitt