remove unused "type ignores" with pyright #7026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
ebcfa94
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0ae9000a.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://pyright-unused-ignores.pydantic-docs2.pages.dev |
samuelcolvin
force-pushed
the
pyright-unused-ignores
branch
from
f4c3ad4
to
843a3b1
Compare
adriangb
approved these changes
Aug 7, 2023
|
looks good but some test failures, guessing some of those are needed. please fix then merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've wanted to do this since #5399 when we switched from mypy to pyright.
This will conflict with #7024 but should be simple to fix.
Selected reviewer: @adriangb