Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shadowing attributes a warning instead of an error #7193

Merged
merged 2 commits into from Aug 22, 2023

Conversation

adriangb
Copy link
Member

@adriangb adriangb commented Aug 21, 2023

Closes #7108

Selected Reviewer: @samuelcolvin

@adriangb
Copy link
Member Author

please review

@cloudflare-pages
Copy link

cloudflare-pages bot commented Aug 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7584523
Status: ✅  Deploy successful!
Preview URL: https://68724c3c.pydantic-docs2.pages.dev
Branch Preview URL: https://make-shadowing-attribute-a-w.pydantic-docs2.pages.dev

View logs

tests/test_main.py Outdated Show resolved Hide resolved
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelcolvin samuelcolvin merged commit caa7801 into main Aug 22, 2023
50 checks passed
@samuelcolvin samuelcolvin deleted the make-shadowing-attribute-a-warning branch August 22, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shadows an attribute in parent __pydantic_init_subclass__ setattr
3 participants