Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old, deprecated code #720

merged 2 commits into from Aug 8, 2019

Remove old, deprecated code #720

merged 2 commits into from Aug 8, 2019


Copy link

@samuelcolvin samuelcolvin commented Aug 6, 2019

Change Summary

Remove the following deprecated functions (all have had deprecation warnings for multiple releases):

  • get_validators is no longer recognised, use __get_validators__
  • Config.ignore_extra is no longer recognised, use Config.extra
  • Config.allow_extra is no longer recognised, use Config.extra


  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • change description file added to changes/,
    see changes/ for details
    on the format

Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #720 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #720      +/-   ##
- Coverage     100%   99.92%   -0.08%     
  Files          15       15              
  Lines        2727     2708      -19     
  Branches      539      532       -7     
- Hits         2727     2706      -21     
- Misses          0        2       +2

@samuelcolvin samuelcolvin added this to the Version 1 milestone Aug 6, 2019
@samuelcolvin samuelcolvin merged commit e6c44ee into master Aug 8, 2019
11 checks passed
@samuelcolvin samuelcolvin deleted the remove-deprecated-code branch Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant