Move function is_pydantic_dataclass from pydantic._internal._dataclasses to pydantic.dataclasses #7213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move is_pydantic_dataclass to pydantic.dataclasses Add test for is_pydantic_dataclass Add documentation for is_pydantic_dataclass
GabrielCappelli
force-pushed
the
make_is_pydantic_dataclass_public
branch
from
2255d4e to
2fe4aff
Compare
|
please review |
adriangb
requested changes
Aug 22, 2023
pydantic-hooky
bot
added
awaiting author revision
…_schema Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
|
please review |
pydantic-hooky
bot
added
ready for review
and removed
awaiting author revision
adriangb
approved these changes
Aug 24, 2023
adriangb
reviewed
Aug 24, 2023
|
please fix conflicts, otherwise LGTM! |
Thank you very much! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Moves is_pydantic_dataclass function from _internals to public api in pydantic.dataclasses.
Adds unit test for is_pydantic_dataclass.
Related issue number
fix #7207
Checklist
Selected Reviewer: @adriangb