Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move function is_pydantic_dataclass from pydantic._internal._dataclasses to pydantic.dataclasses #7213

Merged
merged 4 commits into from Aug 24, 2023
Merged

Move function is_pydantic_dataclass from pydantic._internal._dataclasses to pydantic.dataclasses #7213

merged 4 commits into from Aug 24, 2023

Conversation

GabrielCappelli
Copy link
Contributor

@GabrielCappelli GabrielCappelli commented Aug 22, 2023 •
edited by pydantic-hooky bot

Change Summary

Moves is_pydantic_dataclass function from _internals to public api in pydantic.dataclasses.
Adds unit test for is_pydantic_dataclass.

Related issue number

fix #7207

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@GabrielCappelli
Make func is_pydantic_dataclass public
2fe4aff 
Move is_pydantic_dataclass to pydantic.dataclasses
Add test for is_pydantic_dataclass
Add documentation for is_pydantic_dataclass
@GabrielCappelli GabrielCappelli force-pushed the make_is_pydantic_dataclass_public branch from 2255d4e to 2fe4aff Compare August 22, 2023 16:51
@GabrielCappelli
Copy link
Contributor Author

please review

adriangb
adriangb requested changes Aug 22, 2023
View reviewed changes
pydantic/_internal/_generate_schema.py Outdated Show resolved Hide resolved
pydantic/dataclasses.py Outdated Show resolved Hide resolved
@pydantic-hooky pydantic-hooky bot assigned GabrielCappelli and unassigned adriangb Aug 22, 2023
@GabrielCappelli @adriangb
Use relative import when importing is_pydantic_dataclass in _generate…
b86eb77 
…_schema

Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
@GabrielCappelli
Copy link
Contributor Author

please review

@pydantic-hooky pydantic-hooky bot assigned adriangb and unassigned GabrielCappelli Aug 24, 2023
adriangb
adriangb reviewed Aug 24, 2023
View reviewed changes
pydantic/dataclasses.py Outdated Show resolved Hide resolved
@adriangb
Copy link
Member

please fix conflicts, otherwise LGTM!

@adriangb adriangb enabled auto-merge (squash) August 24, 2023 14:34
@adriangb adriangb merged commit 26f0eab into pydantic:main Aug 24, 2023
47 of 48 checks passed
@GabrielCappelli
Copy link
Contributor Author

please fix conflicts, otherwise LGTM!

Thank you very much! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

Assignees

@adriangb adriangb

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add is_pydantic_dataclass to public API
2 participants
@GabrielCappelli @adriangb