alter the behaviour of dict(model) so that sub-models are nolonger converted to dictionaries #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 2718 2718
Branches 534 534
=====================================
Hits 2718 2718 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
dict(model)as well asfor name, value in model:now don't convert sub-models to dictionaries.I've also completely rewritten the
dict(),json(),copy(),pickle()section of the docs.Related issue number
Fix #508
Checklist
changes/called<pull request or issue id>-<github username>.rst,see changes/README.md for details
on the format