Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix applying SkipValidation to referenced schemas #7381

Merged
merged 1 commit into from Sep 8, 2023

Conversation

adriangb
Copy link
Member

@adriangb adriangb commented Sep 8, 2023

Selected Reviewer: @lig

@adriangb
Copy link
Member Author

adriangb commented Sep 8, 2023

please review

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2aa9075
Status: ✅  Deploy successful!
Preview URL: https://99356d22.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-skip-validation.pydantic-docs2.pages.dev

View logs

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I see this is now matching the pattern used for the InstanceOf dataclass above.

@sydney-runkle
Copy link
Member

Brought to our attention by this discussion.

@adriangb adriangb merged commit 9c03680 into main Sep 8, 2023
48 checks passed
@adriangb adriangb deleted the fix-skip-validation branch September 8, 2023 17:26
@davidhewitt davidhewitt added the relnotes-fix Used for bugfixes. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants