Skip to content

Conversation

dmontagu
Copy link
Contributor

@dmontagu dmontagu commented Aug 16, 2019

Change Summary

Converts .json() to return the contents of the __root__ key for models with a custom root.

Related issue number

#730

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.rst file added describing change
    (see changes/README.md for details)

@dmontagu dmontagu force-pushed the serialize-custom-root branch from 2711e2f to 492f4b2 Compare August 16, 2019 09:38
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #752 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #752   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines        2723   2726    +3     
  Branches      536    537    +1     
=====================================
+ Hits         2723   2726    +3

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good.

dmontagu and others added 5 commits August 16, 2019 03:49
Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>
Co-Authored-By: Samuel Colvin <samcolvin@gmail.com>
@samuelcolvin samuelcolvin merged commit 65d838a into pydantic:master Aug 17, 2019
alexdrydew pushed a commit to alexdrydew/pydantic that referenced this pull request Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants