New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new URL parsing #755
new URL parsing #755
Conversation
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 16 +1
Lines 2723 2786 +63
Branches 536 542 +6
=====================================
+ Hits 2723 2786 +63 |
For me this is ready except for lots of docs to write. Feedback very welcome, preferably before I write all the docs. |
public classes and functions
Other changes
known edge casesunderscores are now allowed in all parts of a domain except the tld. Technically I think this might be slightly wrong - I think in theory the hostname cannot have underscores but subdomains can. However, consider the following two cases:
Without having an exhaustive list of TLDs it would be impossible to differentiate between these two. Therefore underscores are allowed, you could do further validation in a validator if you wanted. Also, chrome currently accepts |
Change Summary
Remove
DSN
and move toUrlStr
toAnyUrl
, and much more.Related issue number
fix #603, fix #541
Checklist
changes/<pull request or issue id>-<github username>.rst
file added describing change(see changes/README.md for details)