Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving typing related objects into typing.py #761

Merged
merged 2 commits into from Aug 21, 2019
Merged

Conversation

samuelcolvin
Copy link
Collaborator

@samuelcolvin samuelcolvin commented Aug 17, 2019

Change Summary

Move everything related to typing into typing.py.

Related issue number

fix #713

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable (none of the docs directly use anything from utils.py).
  • changes/<pull request or issue id>-<github username>.rst file added describing change
    (see changes/README.md for details)

@codecov
Copy link

codecov bot commented Aug 17, 2019

Codecov Report

Merging #761 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #761   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     16    +1     
  Lines        2726   2814   +88     
  Branches      537    578   +41     
=====================================
+ Hits         2726   2814   +88

@samuelcolvin samuelcolvin merged commit 5f63406 into master Aug 21, 2019
12 checks passed
@samuelcolvin samuelcolvin deleted the pydantic.typing branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant