small performance improvements to validators and fields #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
force-pushed
the
tiny-performance-improvements
branch
from
4f1bb4f to
c0386db
Compare
|
turns out this performance improvements aren't so small, ended up at 10-15% improvement on benchmarks. |
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 2726 2729 +3
Branches 537 539 +2
=====================================
+ Hits 2726 2729 +3 |
samuelcolvin
force-pushed
the
tiny-performance-improvements
branch
from
c729c66 to
b9e3eef
Compare
4 tasks
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Shapeis no longer an enum, signatures ofanystr_strip_whitespaceandanystr_length_validatorare corrected.Checklist
Documentation reflects the changes where applicableNAchanges/<pull request or issue id>-<github username>.rstfile added describing change(see changes/README.md for details)