Skip to content

Fix models_json_schema for generic models #7654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 27, 2023
Merged

Fix models_json_schema for generic models #7654

merged 4 commits into from
Sep 27, 2023

Conversation

adriangb
Copy link
Member

Fixes #7630

@adriangb adriangb self-assigned this Sep 26, 2023
@adriangb adriangb requested a review from dmontagu September 26, 2023 22:04
@adriangb adriangb added the relnotes-fix Used for bugfixes. label Sep 26, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 26, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 92a78d0
Status: ✅  Deploy successful!
Preview URL: https://2f4b3998.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-json-schema-generics.pydantic-docs2.pages.dev

View logs

@hramezani hramezani mentioned this pull request Sep 27, 2023
Closed
1 task
@dmontagu dmontagu merged commit ea9aa13 into main Sep 27, 2023
@dmontagu dmontagu deleted the fix-json-schema-generics branch September 27, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmontagu dmontagu dmontagu approved these changes

Assignees

@adriangb adriangb

Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(2.4.0) JSON Schema for Generics models with Literal as agrument is broken
3 participants
@adriangb @dmontagu @hramezani