better error message for TypeError on datetime parsing #766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
While working on #763 I discovered that we had no tests and ugly errors if anything other than a native datetime/date/time/timedelta, string, int or float was passed to those parsers.
Changes:
value_errors
nottype_errors
- more correct.Github doesn't do a very good job of showing it, but this change is mainly just an indentation change plus adding
if isinstance(value, bytes): value = value.decode()
.Checklist
changes/<pull request or issue id>-<github username>.rst
file added describing change(see changes/README.md for details)