Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix populate_by_name migration note about old name #7699

Merged
merged 1 commit into from Sep 29, 2023
Merged

Fix populate_by_name migration note about old name #7699

merged 1 commit into from Sep 29, 2023

Conversation

schneebuzz
Copy link
Contributor

@schneebuzz schneebuzz commented Sep 29, 2023 •
edited by pydantic-hooky bot

Change Summary

Docs change only: Changed note about name of populate_by_name config field before pydantic v2.x.

Related issue number

No issue created for trivial doc change.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist (no code changes)
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@schneebuzz
Copy link
Contributor Author

please review

@adriangb adriangb added the relnotes-ignore Omit this PR from the release notes. label Sep 29, 2023
@adriangb adriangb merged commit 4d0ceea into pydantic:main Sep 29, 2023
58 of 60 checks passed
@adriangb
Copy link
Member

Thanks!

@schneebuzz schneebuzz deleted the docs-fix-config-field-name branch September 29, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

Assignees

@adriangb adriangb

Labels
ready for review relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schneebuzz @adriangb