Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated migration.md to add description of how to push down Field constraints to generics #7751

Merged
merged 1 commit into from Oct 16, 2023

Conversation

NickG123
Copy link
Contributor

@NickG123 NickG123 commented Oct 5, 2023

Change Summary

Added a section to the migration.md to describe the backwards-compatibility breaking change that Field constraints are not automatically pushed down, which based on #6409 is an intended break.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @hramezani

@NickG123
Copy link
Contributor Author

NickG123 commented Oct 5, 2023

please review 😄

@hramezani hramezani added the relnotes-ignore Omit this PR from the release notes. label Oct 16, 2023
@hramezani
Copy link
Member

Thanks @NickG123

@hramezani hramezani merged commit caf8482 into pydantic:main Oct 16, 2023
59 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants