Skip to content

Conversation

alexmojaki
Copy link
Contributor

@alexmojaki alexmojaki commented Oct 11, 2023

Change Summary

All three aliases now fallback to the alias generator if there is one and no other value was specified for that alias.

Related issue number

Closes #7781

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @hramezani

@alexmojaki
Copy link
Contributor Author

please review

Copy link
Contributor

@dmontagu dmontagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, two small change requests

@pydantic-hooky pydantic-hooky bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels Oct 12, 2023
@pydantic-hooky pydantic-hooky bot assigned alexmojaki and unassigned hramezani Oct 12, 2023
@dmontagu dmontagu added the relnotes-fix Used for bugfixes. label Oct 12, 2023
@sydney-runkle sydney-runkle added ready for review and removed awaiting author revision awaiting changes from the PR author labels Oct 16, 2023
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks so much for the contribution! 🌟

@sydney-runkle sydney-runkle enabled auto-merge (squash) October 16, 2023 14:03
@sydney-runkle sydney-runkle merged commit d787222 into pydantic:main Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alias Generator not working with Validation Alias
4 participants