Skip to content

Conversation

laundmo
Copy link
Contributor

@laundmo laundmo commented Oct 17, 2023

Change Summary

Document that unexpected_keyword_argument also happens when using dataclasses and extras are forbidden

Related issue number

None, trivial

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @davidhewitt

@laundmo
Copy link
Contributor Author

laundmo commented Oct 17, 2023

please review

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@davidhewitt davidhewitt merged commit 188018c into pydantic:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants