Skip to content

Support | operator (Union) in PydanticRecursiveRef #7892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2023
Merged

Support | operator (Union) in PydanticRecursiveRef #7892

merged 2 commits into from
Oct 24, 2023

Conversation

alexmojaki
Copy link
Contributor

@alexmojaki alexmojaki commented Oct 21, 2023 •
edited by pydantic-hooky bot
Loading

Change Summary

Adds __or__ and __ror__ methods to PydanticRecursiveRef so that a | b returns a typing.Union.

Related issue number

Closes #7875

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @davidhewitt

@alexmojaki
Copy link
Contributor Author

please review

@davidhewitt davidhewitt added the relnotes-fix Used for bugfixes. label Oct 24, 2023
davidhewitt
davidhewitt approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@davidhewitt davidhewitt merged commit 93e4d23 into pydantic:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees

@davidhewitt davidhewitt

Labels
ready for review relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting unsupported operand type(s) for |: 'PydanticRecursiveRef' and 'NoneType' with PEP 604 formatting and recursive classes
2 participants
@alexmojaki @davidhewitt